Fix JsBuiltIn initialization code to not read root property #4589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSLaguana
reviewed
Jan 23, 2018
lib/Common/Exceptions/Throw.cpp
Outdated
| void Throw::FatalJsBuiltInError() | ||
| { | ||
| AssertMsg(false, "Could not initialize JsBuiltIns!"); | ||
| ReportFatalException(NULL, E_UNEXPECTED, Fatal_JsReentrancy_Error, 0); |
Contributor
There was a problem hiding this comment.
Should this have its own error reason instead of just Fatal_JsReentrancy_Error?
meg-gupta
force-pushed
the
addCheckOnRootPropLd
branch
from
0ffcee3 to
9ab43ed
Compare
MSLaguana
approved these changes
Jan 23, 2018
meg-gupta
force-pushed
the
addCheckOnRootPropLd
branch
from
9ab43ed to
2d9f012
Compare
Contributor
Author
|
Thanks for the review! |
Failing builtin init should be fail fast pass stackoverflow exception above
meg-gupta
force-pushed
the
addCheckOnRootPropLd
branch
from
2d9f012 to
8521489
Compare
jackhorton
reviewed
Jan 23, 2018
Contributor
jackhorton
left a comment
jackhorton
left a comment
There was a problem hiding this comment.
What caused this to happen? Should we be concerned about Intl code doing this?
| { | ||
| #if DBG | ||
| m_isJsBuiltInInitCode = false; | ||
| #endif |
Contributor
There was a problem hiding this comment.
nit: this (and the similar instances below) could still be done in the initializer list?
Contributor
Author
|
The root property maybe overridden and when we inject the jsbuiltin init code, it may be use the overridden property. Same applies for Intl. I checked Intl, it doesn't load any root property other than the Intl object itself. |
Contributor
Author
|
@dotnet-bot test Ubuntu shared_ubuntu_linux_debug |
chakrabot
pushed a commit
that referenced
this pull request
Jan 23, 2018
…d root property Merge pull request #4589 from meg-gupta:addCheckOnRootPropLd Also add assert so that in future we dont write js builtin code to access any root property Fixes OS#15467762
chakrabot
pushed a commit
that referenced
this pull request
Jan 23, 2018
…to not read root property Merge pull request #4589 from meg-gupta:addCheckOnRootPropLd Also add assert so that in future we dont write js builtin code to access any root property Fixes OS#15467762
chakrabot
pushed a commit
that referenced
this pull request
Jan 23, 2018
…ization code to not read root property Merge pull request #4589 from meg-gupta:addCheckOnRootPropLd Also add assert so that in future we dont write js builtin code to access any root property Fixes OS#15467762
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add assert so that in future we dont write js builtin code to access any root property
Fixes OS#15467762