Fix the build #4680
Merged
Fix the build #4680
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethbrenith
commented
Feb 14, 2018
| Js::CallInfo callInfo(static_cast<Js::CallFlags>(generatorInfo->arguments_callInfo_flags), generatorInfo->arguments_callInfo_count, false /*unusedBool*/); | ||
|
|
||
| Js::Arguments arguments(callInfo, (Js::Var*)argVals); | ||
| Js::Arguments arguments(callInfo, unsafe_write_barrier_cast<Js::Var*>(argVals)); |
Contributor
Author
There was a problem hiding this comment.
This matches the pattern from the recent change to lib/Runtime/Library/BoundFunction.cpp
MSLaguana
approved these changes
Feb 14, 2018
jackhorton
approved these changes
Feb 14, 2018
kfarnung
approved these changes
Feb 14, 2018
chakrabot
pushed a commit
that referenced
this pull request
Feb 14, 2018
Merge pull request #4680 from sethbrenith:user/sethb/fix-build Fix a Field-casting issue that showed up in 1.9 and is blocking Ubuntu builds.
chakrabot
pushed a commit
that referenced
this pull request
Feb 14, 2018
Merge pull request #4680 from sethbrenith:user/sethb/fix-build Fix a Field-casting issue that showed up in 1.9 and is blocking Ubuntu builds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a Field-casting issue that showed up in 1.9 and is blocking Ubuntu builds.