Defer ICU initialization until the Intl native interfaces are initialized #5001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ized This modifies a recent change that attempted to initialize ICU before calling any Intl functions in an effort to catch OOM scenarios early. I originally added the code to IntlEngineInterfaceExtensionObject::Initialize, which seemed reasonable, but I forgot that Initialize is always called as part of JavascriptLibrary initialization. As a result, this code was being run on startup at all times. This broke Node-ChakraCore because they have special handling for ICU data, and we were calling u_init before Node's data initialization logic ran. The fix is to initialize ICU in the deferred type handler initialization for the Intl native interfaces, which should only run when script code actually uses Intl (which will always be after Node sets up ICU themselves).
MSLaguana
approved these changes
Apr 17, 2018
kfarnung
approved these changes
Apr 17, 2018
Contributor
Author
|
@dotnet-bot test OSX _no_jit_shared_osx_osx_test please |
chakrabot
pushed a commit
that referenced
this pull request
Apr 17, 2018
…ive interfaces are initialized Merge pull request #5001 from jackhorton:icu/defer-initialize This modifies a recent change that attempted to initialize ICU before calling any Intl functions in an effort to catch OOM scenarios early. I originally added the code to IntlEngineInterfaceExtensionObject::Initialize, which seemed reasonable, but I forgot that Initialize is always called as part of JavascriptLibrary initialization. As a result, this code was being run on startup at all times. This broke Node-ChakraCore because they have special handling for ICU data, and we were calling u_init before Node's data initialization logic ran. The fix is to initialize ICU in the deferred type handler initialization for the Intl native interfaces, which should only run when script code actually uses Intl (which will always be after Node sets up ICU themselves).
Collaborator
|
Testing out mentioning @Microsoft/target-dev in a code review. |
chakrabot
pushed a commit
that referenced
this pull request
Apr 22, 2018
…Kit ICU Merge pull request #5011 from jackhorton:icu/init-windows-kit Third attempt at this after #4984 and #5001, but I have actually confirmed that this makes Node-ChakraCore's chakracore-master branch build, launch, and run Intl code successfully once more. This definitely isn't the best solution, however if we refer to https://github.com/nodejs/node-chakracore/blob/d94b22785fb6ab7dde77cb13b7e95e958e581375/src/node_i18n.cc#L568-L581, we can see that Node somewhat explicitly also does not call u_init if they call udata_setCommonData.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies a recent change that attempted to initialize ICU before calling any Intl functions in an effort to catch OOM scenarios early. I originally added the code to IntlEngineInterfaceExtensionObject::Initialize, which seemed reasonable, but I forgot that Initialize is always called as part of JavascriptLibrary initialization. As a result, this code was being run on startup at all times. This broke Node-ChakraCore because they have special handling for ICU data, and we were calling u_init before Node's data initialization logic ran. The fix is to initialize ICU in the deferred type handler initialization for the Intl native interfaces, which should only run when script code actually uses Intl (which will always be after Node sets up ICU themselves).