SyntaxError on statement without body#6854
Merged
rhuanjl merged 5 commits intochakra-core:masterfrom Oct 15, 2022
Merged
Conversation
rhuanjl
approved these changes
Oct 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the Rules of Automatic Semicolon Insertion:
Therefore, a poc like in #6351 should throw (inside
evaland outside).But CC didn't handle the (unexpected) "end of the input stream" as a
SyntaxError.This applies to
if,for,while,do, ...The parser retrieves the body of such a statement like so:
ChakraCore/lib/Parser/Parse.cpp
Line 10594 in 0a9c082
The
tkEOFcase (insideParser::ParseStatement) is only hit, if it is unexpected:ChakraCore/lib/Parser/Parse.cpp
Lines 10169 to 10180 in 0a9c082
In such a case, CC should always throw, even if
labelledStatement == false.@rhuanjl
Fix #6351
Fix #6553 (Closed as duplicate)
Fix #5128
Report to tc39: tc39/test262#2661