Skip to content

Fix tests #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sindresorhus merged 3 commits into from
Sep 14, 2021
Merged

Fix tests #29

sindresorhus merged 3 commits into from
Sep 14, 2021

Conversation

@msabramo
Copy link
Contributor

@msabramo msabramo commented Sep 14, 2021 •
edited
Loading

Screen Shot 2021-09-13 at 5 24 30 PM

🎉

@msabramo
Fix failing tests
8cff281 
The GitHub Actions CI has been failing for a while because the output is
not rendering colored. This is because `test.js` was setting
`FORCE_COLOR=1` but this happens after the `import` of `chalk` and thus
also after the import within chalk of
[`supports-color`](https://www.npmjs.com/package/supports-color)

JS likes imports to be at the top of files before any other logic, so
it's not really possible to set `FORCE_COLOR` any earlier within
`test.js`. But it *is* possible to set it in `package.json` while
invoking `ava`...

Fixes: chalkGH-27
@msabramo
workflows/main.yml: Remove Node versions 8 and 6
a3fdced 
These versions of Node no longer pass tests, I think because
[yargs-parser only supports node >= 10](
https://github.com/yargs/yargs-parser/blob/main/package.json#L79-L81):

```js
  "engines": {
    "node": ">=10"
  },
```
@msabramo
Add some tests for new -n flag
57bad94
@sindresorhus sindresorhus merged commit 17f70c3 into chalk:bare-nl Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@msabramo @sindresorhus