Internal: Add security fixes from 1.11.x #6079
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![qlty-cloud-legacy[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| if ($form->validate()) { | ||
| $wrong_current_password = false; | ||
| $user_data = $form->getSubmitValues(1); | ||
| $user_data['item_id'] = api_get_user_id(); |
There was a problem hiding this comment.
Variable "user_data" is not in valid camel caps format
| if (isset($_POST['form_sent']) && $_POST['form_sent']) { | ||
| $form_sent = $_POST['form_sent']; | ||
| $elements_posted = $_POST['elements_in_name']; | ||
| $form_sent = (int) $_POST['form_sent']; |
There was a problem hiding this comment.
Variable "form_sent" is not in valid camel caps format
| $form_sent = $_POST['form_sent']; | ||
| $elements_posted = $_POST['elements_in_name']; | ||
| $form_sent = (int) $_POST['form_sent']; | ||
| $elements_posted = Security::remove_XSS($_POST['elements_in_name']); |
There was a problem hiding this comment.
Variable "elements_posted" is not in valid camel caps format
|
Code Climate has analyzed commit d9a4e94 and detected 176 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
ywarnier
reviewed
Mar 14, 2025
| */ | ||
| function attr_on_filter($html) { | ||
| $prefix = uniqid('data-cke-').'-'; | ||
| return preg_replace('/(\s)(on)/i', '$1'.$prefix.'$2', $html); |
Member
There was a problem hiding this comment.
@christianbeeznest This must be updated with the new form in 1.11.x as it was detected that this pattern here did not work
See 8c4e643
Member
|
The rest seems fine. We'll see when the first pentest is over. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.