Skip to content

package maintenance #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
zypA13510 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

package maintenance #4

zypA13510 wants to merge 3 commits into from

Conversation

@zypA13510
Copy link

@zypA13510 zypA13510 commented Nov 19, 2019

some improvements:

  • include a lockfile, many best practice guides recommend committing this file, including npm and yarn themselves
  • pin devDependencies (mocha & should) to their latest major version, again, seems like a good practice
  • bump version to 1.0.0 (stable), this will improve the maintenance score on npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Ephigenia Ephigenia Ephigenia approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zypA13510 @Ephigenia