Skip to content

Use default node version from actions/setup-node #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
trivikr wants to merge 1 commit into from
Closed

Use default node version from actions/setup-node #233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,8 @@ jobs:

steps:
- name: Checkout Repo
uses: actions/checkout@v2

- name: Use Node.js 16
uses: actions/setup-node@v1
with:
node-version: 16.x
uses: actions/checkout@v3
uses: actions/setup-node@v3

- name: Install Dependencies
run: yarn --frozen-lockfile
Expand Down
8 changes: 2 additions & 6 deletions .github/workflows/version-or-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,8 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout Repo
uses: actions/checkout@v2

- name: Use Node.js 16
uses: actions/setup-node@v1
with:
node-version: 16.x
uses: actions/checkout@v3
uses: actions/setup-node@v3

- name: Install Dependencies
run: yarn --frozen-lockfile
Expand Down
1 change: 0 additions & 1 deletion action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
name: Changesets
description: A GitHub action to automate releases with Changesets
runs:
using: "node16"
Copy link
Member

@Andarist Andarist Nov 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what exact impact that would have on consumers of this action though? isn't it recommended to use an explicit version here?

main: "dist/index.js"
inputs:
publish:
Expand Down