fix: remove git global config flag #94
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@mitchellhamilton @Andarist Can you please take a look at this? |
Andarist
approved these changes
Dec 22, 2021
Member
Andarist
left a comment
Andarist
left a comment
There was a problem hiding this comment.
LGTM, @mitchellhamilton do you see any risks associated with this? I couldn't find any
emmatown
approved these changes
Dec 23, 2021
Merged
Member
|
This got merged in as part of this PR #128 because I couldn't push to this fork. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running this action inside a self-hosted GitHub runner that has an Alpine equivalent barebones environment, the changeset action fails since it's trying to set git user & email on global config that looks for
$HOME/.gitconfig.Self-hosted instances might also have a shared VM running multiple jobs, updating global git config might pollute the global configs which is not expected.