Skip to content

Don't error on symlinks and executables when they don't have to be touched anyway #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Andarist merged 12 commits into from
Jan 27, 2026
Merged

Don't error on symlinks and executables when they don't have to be touched anyway #46

Andarist merged 12 commits into from
Jan 27, 2026
+426 −32

Conversation

@Andarist
Copy link
Member

@Andarist Andarist commented Jan 13, 2026

suggested by @dotansimha

@Andarist Andarist requested a review from s0 January 13, 2026 15:10
@dotansimha dotansimha mentioned this pull request Jan 13, 2026
Closed
@dotansimha
Copy link
Contributor

dotansimha commented Jan 13, 2026

related: changesets/action#523

@Andarist @dotansimha
Don't error on symlinks and executables when they don't have to be to…
104ac00 
…uched anyway

Co-authored-by: Dotan Simha <dotan@the-guild.dev>
s0
s0 previously approved these changes Jan 13, 2026
View reviewed changes
@s0
Copy link
Member

s0 commented Jan 13, 2026

Looks good, but integration tests need to be updated to allow for unchanged symlinks, but still throw an error for symlinks that changed and are not ignored.

s0
s0 previously approved these changes Jan 14, 2026
View reviewed changes
@s0
Copy link
Member

s0 commented Jan 14, 2026

Hmm tests still failing

@Andarist
Copy link
Member Author

Andarist commented Jan 14, 2026

@s0, ye - I vibocoded them and couldn't quickly test locally because I didn't have tokens setup for the integration tests so decided to use CI to verify the change for me ;p I'll look into fixing this later

@Andarist
Copy link
Member Author

Andarist commented Jan 19, 2026

In the process of working on this I have diagnosed an issue in the isomorphic-git and opened a PR to address it: isomorphic-git/isomorphic-git#2271

@Andarist Andarist force-pushed the Andarist-patch-1 branch 4 times, most recently from bf3055e to 6c8c084 Compare January 24, 2026 22:34
@Andarist Andarist force-pushed the Andarist-patch-1 branch 3 times, most recently from a1a7daf to bcf398e Compare January 24, 2026 23:11
@Andarist
Copy link
Member Author

Andarist commented Jan 26, 2026

This is now ready to be stamped and merged, cc @s0

@Andarist Andarist requested review from bluwy and s0 January 26, 2026 07:50
bluwy
bluwy approved these changes Jan 27, 2026
View reviewed changes
Copy link

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not familiar with this package but the code seems ok to me.

@Andarist Andarist merged commit d12678c into main Jan 27, 2026
4 checks passed
@Andarist Andarist deleted the Andarist-patch-1 branch January 27, 2026 17:29
@github-actions github-actions bot mentioned this pull request Jan 27, 2026
Merged
@s0
Copy link
Member

s0 commented Jan 27, 2026

Thanks for getting this over the line @Andarist 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bluwy bluwy bluwy approved these changes

@s0 s0 Awaiting requested review from s0

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Andarist @dotansimha @s0 @bluwy