Minor issues for 2DC board after first review #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also switches the key from KEY_DOWN to KEY_F1. This is in preparation to use similar keys for stopping the charging process on boards with more than one connector. (While at, some whitespace is dropped) Signed-off-by: Michael Heimpold <michael.heimpold@chargebyte.com>
- use different keys for both charging stop buttons (now KEY_F1/KEY_F2) - remove the polarity hack for first ethernet: not needed because we have mosfets - fix eeprom compatible - move nvmem-layout to RTC node since we store the MAC addresses in the RTC EEPROM, not in the DT EEPROM - USB1 is dual role, not fixed host Note: untested due to lack of hardware. Signed-off-by: Michael Heimpold <michael.heimpold@chargebyte.com>
lategoodbye
approved these changes
Sep 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.