-
Notifications
You must be signed in to change notification settings - Fork 348
feat: Granular progress bar completion #680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
This is SO good. We'll need to review this properly but I think it's safe to say we should get this one in. |
|
Hi there! Just a note that we haven't forgotten about this one and we still plan to get it in. Thanks for your patience with it! |
|
@meowgorithm I recently thought of a few tweaks that could make progress more extensible and smooth. Currently, filled blocks use the ASCII full block meaning only one color can be used per gradient block. Using the ANSI half block instead means you can use one color in the foreground (left-side) and one in the background (right-side) hence doubling the color resolution. Also, the gradient implementation limits folks to 2 colors but a more generalized Would you be interested in those changes as well? I totally understand if you don't :) I just want to show them to you now so the library spec doesn't change twice if you decide to roll with it ;) |
Mentioned this in Discord, but referencing here for others as well: #838 -- that PR should work for what you're looking for, and should still be forward-compatible with some of the additional ideas you have. Though of course, the new implementation would be v2 only. |


A progress cell currently only has two states: complete, incomplete.
This PR let's progress bars be much more granular by having 9 possible states for the bar which drastically increases resolution.
Animations render at 60fps by default. It's a shame to have smoothness limited by progress bar resolution ;)