chore(textarea): remove pointer receiver on update and view #858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meowgorithm
force-pushed
the
textarea-unpointer
branch
from
8f63a29 to
4b3beec
Compare
Member
|
@meowgorithm I believe we had to do that to fix an issue with the textarea not scrolling and moving the cursor on some events like a paste event and others. But I do think we should still remove the pointer receiver |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@aymanbagabas: correct me if I'm wrong here, but I don't think we want pointers in
textarea'sUpdateandModel, right?