Conversation
Deploying charming with
|
| Latest commit: |
eeb8a53
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://cda2f2c9.charming-a13.pages.dev |
| Branch Preview URL: | https://rough.charming-a13.pages.dev |
There was a problem hiding this comment.
Pull Request Overview
This PR introduces updates to improve the rendering system by integrating a new TestRenderer and propagating a renderer instance throughout the rendering pipeline while closing issue 357. Key changes include:
- Adding tests for a custom TestRenderer that validates element creation and attribute/event assignment.
- Refactoring core rendering files (renderer.js, render.js, and mark.js) to use a centralized Renderer instance.
- Updating exports in index.js to include the Renderer class.
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/renderer.spec.js | Adds a TestRenderer with customized element creation logic. |
| test/mark.spec.js | Updates tests to validate inclusion of the Renderer instance. |
| src/renderer.js | Introduces a Renderer class with methods for element creation, events, and attributes handling. |
| src/render.js | Modifies render() to accept and pass a renderer instance in the context. |
| src/mark.js | Updates attribute/event application to use the renderer's methods, avoiding direct DOM event listener management. |
| src/index.js | Exports the Renderer class for broader usage. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (1)
src/mark.js:30
- [nitpick] Avoid shadowing the 'options' parameter within the decorator loop by using a different variable name to improve clarity.
for (const [type, decorator] of decorators) {
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close: https://github.com/charming-art/charming/issues/357
Notebook
Test