maintainAspectRatio aligns to container width only

[ditor2]

Look at this little fiddle:

https://jsfiddle.net/ycdbv5sq/

Resize the chart by increasing its width. The bottom of the chart will be clipped.
This is because maintainAspectRatio always takes the width as base and calculates (and sets) the heigth from it (never does it from opposite approach), as I see in getMaximumSize:.

  width = Math.max(0, width - margins.width);
  height = Math.max(0, aspectRatio ? Math.floor(width / aspectRatio) : height - margins.height);

maintainAspectRatio should do the following, IMHO:

• calculate chart height based on width (and ratio)
• if this height is smaller or equal to the current height of the container, render the chart with this size
• if the height calculated above is greater than the current height of the container, calculate the width of the chart based on the height and the ratio (and use this width for rendering)

This could ensure that the entire chart is visible.

[etimberg]

This will require careful investigation because this feature is fragile. It's quite easy to break existing users by implementing the feature above. I think we'll need some kind of resize mode selector to make this optional.

[ditor2]

Thank you.
I agree that it would require a new option, at least a default-off boolean one to turn on this new feature.

[kurkle]

I think I'd include this in v4 as a breaking change, without any additional options (we have plenty).

[saxicek]

My opinion is that the use case above does not justify the change. In #11005 you can see that it caused big issue to many people and there is no good solution for it.

On the other hand, the solution for the problem from this issue is quite easy - when your height is limited, you can also limit width accordingly. Simply add max-width: 700px to the div element (or other limit as per your aspect) and you are fine - see the updated https://jsfiddle.net/2qpv9d57/.

Would you please consider revert of #10646?