Check for isNaN before building number formatter options#11238
Merged
etimberg merged 2 commits intochartjs:masterfrom Apr 19, 2023
Merged
Check for isNaN before building number formatter options#11238etimberg merged 2 commits intochartjs:masterfrom
etimberg merged 2 commits intochartjs:masterfrom
Conversation
When datasets have values approaching Number.MAX_VALUE, the tick calculations might result in infinity and eventually NaN. Passing NaN for minimumFractionDigits or maximumFractionDigits will make the number formatter throw. Instead we check for isNaN and use a fallback value so the formatter does not throw.
Contributor
Author
|
Originally discovered in our visualization tool which uses chart.js. We had users with datasets containing Number.MAX_VALUE and it was crashing our plot panels. |
LeeLenaleee
reviewed
Apr 19, 2023
Co-authored-by: Jacco van den Berg <jaccoberg2281@gmail.com>
LeeLenaleee
approved these changes
Apr 19, 2023
etimberg
approved these changes
Apr 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When datasets have values approaching Number.MAX_VALUE, the tick calculations might result in infinity and eventually NaN. Passing NaN for minimumFractionDigits or maximumFractionDigits will make the number formatter throw. Instead we check for isNaN and use a fallback value so the formatter does not throw.