Fix documentation about how to manage own custom plugin for types#11244
Merged
LeeLenaleee merged 1 commit intochartjs:masterfrom Apr 20, 2023
Merged
Fix documentation about how to manage own custom plugin for types#11244LeeLenaleee merged 1 commit intochartjs:masterfrom
LeeLenaleee merged 1 commit intochartjs:masterfrom
Conversation
se-bastiaan
approved these changes
Apr 20, 2023
etimberg
approved these changes
Apr 20, 2023
Contributor
Author
|
@etimberg I didn't add any test case for this "special" case. MAybe it could be acceptable to have it in the plugins project? What do you think? |
LeeLenaleee
approved these changes
Apr 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix types from plugins.
Error: node_modules/chartjs-plugin-annotation/types/index.d.ts:6:13 - error TS2428: All declarations of 'PluginOptionsByType' must have identical type parameters.6 interface PluginOptionsByType<TType extends ChartType> {