Add missing feature for disabling plugins in TyeScript

[stockiNail]

Fix #11398

@etimberg @LeeLenaleee @kurkle first of all and as you know, my experience on TS is limited. Therefore not sure if the issue can be solved differently.
Furthermore there are 2 thoughts:

1. It sounds to me this is a breaking change because the casting could be needed to access to chart plugins options (maybe I'm wrong)
2. All plugins, which are using the defaults (for instance zoom, annotation, datalabels), should augment also the DefaultsPluginOptionsByType, see changes on the doc.

[LeeLenaleee]

This (renaming interfaces) can indeed possibly break some things.

For now in v4 I think the best approach is to define the interfaces as this:

export interface PluginOptionsByType<TType extends ChartType> {
  decimation: DecimationOptions | false;
  filler: FillerOptions | false;
  legend: LegendOptions<TType> | false;
  subtitle: TitleOptions | false;
  title: TitleOptions | false;
  tooltip: TooltipOptions<TType> | false;
}
export interface PluginChartOptions<TType extends ChartType> {
  plugins: PluginOptionsByType<TType> ;
}

This would make it fail to disable all plugins but I think that would be the use case that would be used the least and we never heared anymore complain about it.

Worst case they can put a // @ts-ingore above the line.

But with this we mostly solve the issue. Without too much breaking possibility. In theory this can still do some weird things but these are the more correct types.

[etimberg]

I agree with @LeeLenaleee. This could be a breaking change for other users of those types.

[stockiNail]

@LeeLenaleee @etimberg thanks a lot for feedbacks! I have updated the PR as suggested by @LeeLenaleee and I also think it makes sense to do it int his way.

[LeeLenaleee]

This cast is not needed now anymore right?

[stockiNail]

No, viceversa. It is now needed (or we need to use ts-ignore). With previous PR impl, having 2 interfaces and defaults was extending the interface without the possible false value) it wasn't needed. Now it's needed because TS can not recognize the type:

[types] test/types/defaults.ts(5,30): error TS2339: Property 'display' does not exist on type 'false | TitleOptions'.
[types]   Property 'display' does not exist on type 'false'.

[LeeLenaleee]

idem

[stockiNail]

See #11403 (comment)

[kleinfreund]

I think this PR broke TypeScript code in 4.3.1 that has assignments like this:

ChartJS.defaults.plugins.tooltip.bodyFont = {
  size: 12,
}

Error:

Property 'bodyFont' does not exist on type 'false | TooltipOptions<keyof ChartTypeRegistry>'.
  Property 'bodyFont' does not exist on type 'false'.

Workaround:

if (ChartJS.defaults.plugins.tooltip) {
  ChartJS.defaults.plugins.tooltip.bodyFont = {
    size: 12,
  }
}