Use ticks.maxTicksLimit to limit gridLines in a similar way#1863
Merged
etimberg merged 5 commits intochartjs:v2.0-devfrom Jan 7, 2016
morleyzhi:v2.0-dev
Merged
Use ticks.maxTicksLimit to limit gridLines in a similar way#1863etimberg merged 5 commits intochartjs:v2.0-devfrom morleyzhi:v2.0-dev
etimberg merged 5 commits intochartjs:v2.0-devfrom
morleyzhi:v2.0-dev
Conversation
added 5 commits
January 7, 2016 10:44
…eOrDefault for resolving the maxTicksLimit option
etimberg
added a commit
that referenced
this pull request
Jan 7, 2016
Use ticks.maxTicksLimit to limit gridLines in a similar way
Member
|
Looks good. Thanks @morleyzhi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #1859.
Right now, there's no way to limit the number of gridlines that appear if you've hidden ticks. This is what it looks like before this PR:
I made it so that if you provide
maxTicksLimit, it limits gridLines, so now this graph will look like this:Unlike maxTicksLimit, we don't default to 11 if the option isn't provided. I did this because it blew up the tests, and I didn't feel comfortable changing the test output and breaking people's setups. (But if you want me to preserve that 11-tick default behavior, it should be easy for me to do.)
I also added maxTicksLimit to scale docs, and some contributing notes.
👍