Add option to disable line drawing#1887
Merged
etimberg merged 1 commit intochartjs:v2.0-devfrom Jan 14, 2016
mathiask88:v2.0-dev
Merged
Add option to disable line drawing#1887etimberg merged 1 commit intochartjs:v2.0-devfrom mathiask88:v2.0-dev
etimberg merged 1 commit intochartjs:v2.0-devfrom
mathiask88:v2.0-dev
Conversation
Contributor
Author
|
Oh, I missed the tests :) |
Member
|
+1 to merge as soon as tests pass |
Contributor
Author
|
Tests are passing now. I initially thought the test would inherit from the global config ;) Don't know if you want a new test case to test if the lines are not being drawn. |
Member
|
@mathiask88 a test covering not drawing the line would be nice if you can add one. If not, it's okay. |
Contributor
Author
|
@etimberg I added a test. Is that ok? Did not look closely at all tests. |
etimberg
added a commit
that referenced
this pull request
Jan 14, 2016
Add option to disable line drawing
Member
|
Looks good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an option to disable the line drawing between points, so a Line Chart turns into a scatter plot. See #1880 for more details.