Add some optimizations to often used functions#1893
Merged
etimberg merged 1 commit intochartjs:v2.0-devfrom Jan 12, 2016
mathiask88:updateOptimizations
Merged
Add some optimizations to often used functions#1893etimberg merged 1 commit intochartjs:v2.0-devfrom mathiask88:updateOptimizations
etimberg merged 1 commit intochartjs:v2.0-devfrom
mathiask88:updateOptimizations
Conversation
etimberg
added a commit
that referenced
this pull request
Jan 12, 2016
Add some optimizations to often used functions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses some optimizations:
Using
callinstead ofapplyis ~80% faster and the flexibility of dynamic additional arguments is currently not usedUsing
sliceon theargumentsobject prevents V8 from optimising. Replaced with much fasterfor..loop(
helpers.configMergeargument slice was left as is, because it is not called very often)Replaced slow
for..inwithfor..loop/cc #1882