Small optimizations#1900
Merged
etimberg merged 5 commits intochartjs:v2.0-devfrom Jan 16, 2016
mathiask88:smallOptimizations
Merged
Small optimizations#1900etimberg merged 5 commits intochartjs:v2.0-devfrom mathiask88:smallOptimizations
etimberg merged 5 commits intochartjs:v2.0-devfrom
mathiask88:smallOptimizations
Conversation
Member
|
Great! I'll take a look. |
Member
|
@mathiask88 other than that one change, I didn't see anything that jumped out at me |
Member
|
@mathiask88 is this good to go now? I saw that the commit adding the caching system for measure text was changed to address your comment on the missed font change. |
Contributor
Author
|
I think so, if you are ok with this changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@etimberg Look at the commit messages for more info and leave line comments as much as you like :)