Fixed legendCallback() html generation#2254
Merged
etimberg merged 3 commits intochartjs:v2.0-devfrom Apr 13, 2016
Merged
Conversation
Fixed legendCallback's html generation so that the span lies next to the text instead of being around it.
Member
|
@dibsyjr1 can you change the source files instead of the built files? Otherwise these changes will be lost when we rebuild |
Fixed the generateLegend function to create the colour block next to the text instead of around it.
Contributor
Author
|
@etimberg is that better? Didn't change the built file back but if you want me to, let me know. |
Member
|
@dibsyjr1 if you could change the built file back, I will merge this :) |
Contributor
Author
|
Fixed :) |
Member
|
Thanks! |
Contributor
Author
|
No worries! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed legendCallback's html generation so that the span lies next to the text instead of being around it.
Not sure if i've done this correctly (it's my first PR). If you need any changes made then comment on the Issue I created.