Skip to content

Using the dynamic absolute position even for relative elements#2255

Merged
etimberg merged 1 commit intochartjs:masterfrom
HarvestingClouds:patch-1
Apr 15, 2016
Merged

Using the dynamic absolute position even for relative elements#2255
etimberg merged 1 commit intochartjs:masterfrom
HarvestingClouds:patch-1

Conversation

@HarvestingClouds
Copy link
Contributor

This will work with both relative and absolute position for the chart and will apply the tooltips appropriately.

…t is having relative position

This will work with both relative and absolute position for the chart
@etimberg
Copy link
Member

@HarvestingClouds is there anyway you could port this for v2?

@HarvestingClouds
Copy link
Contributor Author

HarvestingClouds commented Apr 15, 2016

@etimberg I have made the change to the dev branch and implemented the similar change for that sample and in shorter and more efficient manner. I opened pull request "#2263" for that change. I am new to the GitHub process and generated pull request for the master branch whereas I intended to only submit changes to the dev branch. I just found that I created the Pull request into the dev branch only. But I see some errors where there should be none. The errors seems to be in Travis-CI environment variable setting rather than the change I have proposed. Please help me in getting the change to appropriate channel.

@etimberg etimberg merged commit 98a995d into chartjs:master Apr 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants