Added unit test for doughnut rotation/circumference, fix for rotation = 0#2273
Merged
etimberg merged 1 commit intochartjs:v2.0-devfrom Apr 16, 2016
Merged
Added unit test for doughnut rotation/circumference, fix for rotation = 0#2273etimberg merged 1 commit intochartjs:v2.0-devfrom
etimberg merged 1 commit intochartjs:v2.0-devfrom
Conversation
…circumference properties
Member
|
Thanks @mdehoog |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a follow up for #2271, I've added a unit test that tests the doughnut chart with non-default rotation/circumference properties.
There was a bug in the initial version where a value of 0 for rotation would revert the rotation to the default value of
Math.PI * -0.5; this has been fixed.Also replaced the
1.999999multiplier in thecalculateCircumferencefunction with2.0, and updated the values in the unit test to suit. The1.999999isn't required any more, I believe due to the arc'sinRangechange in #2271. Using2.0allows us to be more accurate in the unit tests.