Skip to content

[TEST PR] New scale test for auto skipper.#3740

Closed
KoyoSE wants to merge 4 commits intochartjs:masterfrom
KoyoSE:fineScaleTest
Closed

[TEST PR] New scale test for auto skipper.#3740
KoyoSE wants to merge 4 commits intochartjs:masterfrom
KoyoSE:fineScaleTest

Conversation

@KoyoSE
Copy link
Contributor

@KoyoSE KoyoSE commented Dec 25, 2016

Note: This is a test code for auto skipper. Please use it for reference.
(Reference #3233 )

I tested the display method not using auto skipper.
For testing, the code is not beautiful.

Summary

Extend Chart.Scale etc.
Two scale type ( linear2 and linear3 ) were added.
Fixed several bugs on the current Chart.Scale.
A sample html was added.
2016-12-25

linear

Run the original linear scale type with extended Chart.Scale.
This means that the existing scale will work.
Other existing scales also work.
In this case, autoSkip is used.

linear2

Display the scale in a way not using autoSkip.
Ticks are divided into three levels to control label display.
I adjusted it display close to the original linear.

linear3

It is a scale that changes the scale calculation parameter and reduces the number of tick marks.
This will be useful for displaying fine scales.

jsFiddle

It was harder than I imagined. 😅

@KoyoSE
Copy link
Contributor Author

KoyoSE commented Dec 26, 2016

Additional notes : When min max stepsize is set, I think linear scale is correct. The step should start from min. 😃
https://github.com/chartjs/Chart.js/blob/master/src/core/core.ticks.js#L68-L75
I forgot this code.

@KoyoSE
Copy link
Contributor Author

KoyoSE commented Dec 26, 2016

Changed

2016-12-26
jsFiddle

My opinion

linear2, linear3, the display of the scale is fine and it is not simple. To merge with the original, adjustment is still necessary.

@KoyoSE
Copy link
Contributor Author

KoyoSE commented Jan 13, 2017

@etimberg
Please close this PR whenever you like. 😃

@etimberg etimberg closed this Feb 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants