Fixed misplaced data points on category scale#4062
Merged
etimberg merged 5 commits intochartjs:masterfrom Mar 27, 2017
Merged
Conversation
etimberg
requested changes
Mar 23, 2017
src/scales/scale.category.js
Outdated
| if (value !== undefined && isNaN(index)) { | ||
| // If value is a data object, then index is the index in the data array, | ||
| // not the index of the scale. We need to change that. | ||
| var valueCategory = me.isHorizontal() ? value.x : value.y; |
Member
There was a problem hiding this comment.
this will error if value is undefined
Contributor
Author
There was a problem hiding this comment.
You're totally right, thank you for your feedback. Addressed this on the latest commit.
etimberg
approved these changes
Mar 24, 2017
simonbrunel
requested changes
Mar 24, 2017
Member
simonbrunel
left a comment
simonbrunel
left a comment
There was a problem hiding this comment.
It fails because value can also be null
Contributor
Author
|
@simonbrunel But that would be catched by line 77, right? |
Member
|
Contributor
Author
|
@simonbrunel Please review |
simonbrunel
approved these changes
Mar 27, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verifying the index before processing
getPixelForValueSee #4060