Don't shift timescale bars on barchart#4063
Conversation
simonbrunel
left a comment
There was a problem hiding this comment.
I don't think that's the correct approach: the bar controller should not be aware of specific scale types but simply rely on the base scale interface.
Do you have a fiddle that showcase the issue?
|
Here's an example of current behaviour: https://codepen.io/anon/pen/NpzGrZ. |
etimberg
left a comment
There was a problem hiding this comment.
I agree that this PR fixes the issue, but I also agree with @simonbrunel that the bar controller should not care about the type of axis. What this means is that we need to find the proper abstraction between the axes and the controllers to ensure that the type and category axes return the correct information.
|
Your problem should hopefully be solved by the recently checked in I think this PR should be closed now that we have another solution. The bar controller shouldn't care about the time scale. |
|
Thanks! |
Summary
This PR (naively) resolves issue with bars alignment on time scale, by early returning.
Fixes #2415.