Added extra option 'useLineStyle'#4496
Closed
devina10192 wants to merge 2 commits intochartjs:masterfrom
Closed
Conversation
Added extra option 'useLineStyle' for getting Legends as a line
Contributor
|
@devina10192 could you rebase this PR? |
Member
|
Should we close this one in favor of #4890? |
Member
|
@simonbrunel I am ok with that |
Contributor
|
Seems like a good idea to me too @devina10192 thanks for the contribution. Since #4890 provides the same functionality in a more configurable way I'm going to close this PR for now to help keep us organized. Please feel free to comment still if you have feedback on the approach. Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added extra option 'useLineStyle' for getting Legends as a line