Check for missing values before getting radius#4664
Closed
kesmit13 wants to merge 1 commit intochartjs:masterfrom
Closed
Check for missing values before getting radius#4664kesmit13 wants to merge 1 commit intochartjs:masterfrom
kesmit13 wants to merge 1 commit intochartjs:masterfrom
Conversation
Member
|
Funny, I'm about to submit a PR to enable scriptable options for the bubble chart (example), fixing this issue at the same time. |
etimberg
reviewed
Aug 17, 2017
Member
etimberg
left a comment
etimberg
left a comment
There was a problem hiding this comment.
We should probably write a test to cover this case. Other than that I think the code looks OK. @simonbrunel does this merge with the work you've been doing?
Member
|
This code doesn't exist anymore in my branch |
Member
|
PR submitted, fix at line 172. |
Member
|
Fixed in #4671 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The value object is verified before attempting to access the radius. This may result in a slight behavior difference since the original code would not allow a radius of zero. I think that allowing a zero radius is legitimate use though.