Closed
Conversation
simonbrunel
requested changes
Aug 21, 2017
Member
simonbrunel
left a comment
simonbrunel
left a comment
There was a problem hiding this comment.
@silverspectro can you rebase this PR on master and remove changes related to your other PR #4638?
silverspectro
force-pushed
the
fix-tooltip-text-alignment
branch
from
952f85f to
c13a1c3
Compare
Author
|
is this okay ? |
etimberg
requested changes
Aug 21, 2017
src/core/core.tooltip.js
Outdated
|
|
||
| // Titles | ||
| this.drawTitle(pt, vm, ctx, opacity); | ||
| this.drawTitle(pt, vm, ctx, opacity, tooltipSize); |
Member
There was a problem hiding this comment.
Not sure this is the best solution. tooltipSize is just vm.width and vm.height (line 792). I would prefer just using vm.width and vm.height inside these functions since it avoids another parameter
src/core/core.tooltip.js
Outdated
|
|
||
| // Draw Title, Body, and Footer | ||
| pt.x += vm.xPadding; | ||
| // pt.x += vm.xPadding; |
Member
There was a problem hiding this comment.
[nit] please remove commented code
- Delete TooltipSize to use vm.height and vm.width - Delete commented code
Contributor
|
@silverspectro your changes are making the tests fail
|
Contributor
|
You may be interested in #4890 which is also defining |
Member
|
Closing due to inactivity |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.