Make bar tests more stable

[andig]

Follow-up to #4686

My recipe for doing this semi-automatic is this:

• use SublimeText or Atom that support multi-selection via Cmd-D
• extract all line numbers, failures and expectations using regex (?s)Expected ([0-9.]+)( to be close to pixel (\d+)(.*? )at .*?test/specs/controller.bar.tests.js:)(\d+):(\d+)
• copy to new file and replace same regex by \5 \3 \1 - this gives line number, current expectation, actual value
• then simply step through the lines, multi-select and replace across the file

[simonbrunel]

Similar to a talk we had, can we keep it in this form: w: 92 / 2 (sample size / number of stacks)

[andig]

Fixed

[simonbrunel]

Thanks a lot @andig

[etimberg]

Looks great! Thanks @andig

[andig]

@simonbrunel if there's another batch of tests needing cleanup feel free to let me know. I've just rebased #4646 and didn't need to touch the bar controller. The cleanup is definitely worth the efforts :)

[simonbrunel]

Sounds really good, thanks @andig :)

I guess most of the controller.*.tests.js would need this kind of update.

I'm wondering if we could limit the changes by using global options, for example:

describe('Chart.controllers.bar', function() {
  beforeAll(function() {
    this._defaults = Chart.helpers.clone(Chart.defaults);
    Chart.helpers.merge(Chart.defaults, {
      global: {
        legend: false,
        title: false
      },
      scale: {
        display: false
      }
    });
  });

  afterAll(function() {
    Chart.helpers.merge(Chart.defaults, this._defaults);
  });
});

Not sure about this in before/afterAll, would need to check if it's the same.

Then, only need to change expectations but not options for every tests.