Make major ticks optional and off by default#4723
Merged
etimberg merged 1 commit intochartjs:masterfrom Sep 8, 2017
Merged
Conversation
etimberg
approved these changes
Sep 5, 2017
Member
|
Based on this issue, I think we should also disable major alignment if |
benmccann
force-pushed
the
majorTicksOptional
branch
from
00c50b5 to
9bac7ce
Compare
Contributor
Author
|
Ok, I agree at least in the short term because the alignment isn't working very well currently. On that issue, he said |
Contributor
Author
|
I've updated the PR to make that change as well |
simonbrunel
approved these changes
Sep 8, 2017
yofreke
pushed a commit
to yofreke/Chart.js
that referenced
this pull request
Dec 30, 2017
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Leave the major tick functionality off by default. It still has some polishing left to do and many people don't expect the change