Respect min and max when building ticks#4860
Merged
simonbrunel merged 1 commit intochartjs:masterfrom Oct 20, 2017
Merged
Conversation
benmccann
force-pushed
the
min-max-fix
branch
from
a33f8e8 to
da5a513
Compare
simonbrunel
approved these changes
Oct 19, 2017
Member
simonbrunel
left a comment
simonbrunel
left a comment
There was a problem hiding this comment.
Looks good, I thought it would have more impact on unit tests.
Could you please update the fiddle in this comment to see the new behavior?
Member
|
Looks good to me as well |
etimberg
approved these changes
Oct 19, 2017
Contributor
Author
|
Here's a screenshot demonstrating the fix.
I'm curious for next time though... How do I update a fiddle with a locally built version of Chart.js? |
Member
|
No good way to update a fiddle. Usually you have to copy the built version into the HTML section inside a script tag .... not super great or performant |
yofreke
pushed a commit
to yofreke/Chart.js
that referenced
this pull request
Dec 30, 2017
Generate time scale ticks (`ticks.source: 'auto'`) based on the effective visualized range instead of the actual data range, meaning that the computed units and/or step size may change if the time options min and max are different from the data min and max.
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
Generate time scale ticks (`ticks.source: 'auto'`) based on the effective visualized range instead of the actual data range, meaning that the computed units and/or step size may change if the time options min and max are different from the data min and max.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a potential alternative to #4844
Replaces #4844
Fixes #4845