Bugfix: Improve polyfill function of log10 to return whole powers of 10#5275
Merged
etimberg merged 2 commits intochartjs:masterfrom Feb 20, 2018
Merged
Bugfix: Improve polyfill function of log10 to return whole powers of 10#5275etimberg merged 2 commits intochartjs:masterfrom
etimberg merged 2 commits intochartjs:masterfrom
Conversation
as integer values, as it caused endless loop in IE11 in the tick
creation loop.
etimberg
previously approved these changes
Feb 16, 2018
simonbrunel
approved these changes
Feb 20, 2018
etimberg
approved these changes
Feb 20, 2018
Contributor
|
@jcopperfield Simon, Evert, and I wanted to thank you for your contributions to Chart.js. Would you be interested in becoming a maintainer? We're looking for folks to help us review incoming PRs and triage issues so that we can keep the community active and be more timely in giving feedback. |
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
…10 (chartjs#5275) * Bugfix: Improve polyfill function of log10 to return whole powers of 10 as integer values, as it caused endless loop in IE11 in the tick creation loop. * Compare floating-point numbers directly instead of using unnecessary division.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
helpers.log10polyfill function doesn't return precise integer values for all whole powers of 10.This can cause an infinite loop as issued in #5264
The proposed PR uses a multiplication with
Math.LOG10Einstead of a division byMath.LN10. This improves the accuracy, however as is shown in the table below, not all computed powers are correct, thus leading to the extra check, which is slower, but more accurate.