Proper tick position for right positioned axis#5401
Merged
etimberg merged 2 commits intochartjs:masterfrom Apr 11, 2018
Merged
Conversation
Member
Author
|
@simonbrunel how do you feel about an image based test for this? It might be complicated even with fonts hidden on the axes |
Member
|
That could work: one image with scales all around and no text. I would also make sure that nothing else appears, only the ticks at the expected positions. Then you should try to run the test with the actual bug and see if it fails. |
simonbrunel
previously approved these changes
Apr 10, 2018
Member
Author
|
@simonbrunel will give that a shot and see how it goes |
Member
Author
|
Added a test |
simonbrunel
approved these changes
Apr 11, 2018
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
* Proper tick position for right positioned axis * Test for tick mark drawing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #5178 the position of tick marks was changed inadvertently for a right positioned axis. This PR puts the tick marks back to the correct location.
Resolves #5400