Update integration docs: first method only works with Webpack#5555
Merged
simonbrunel merged 2 commits intochartjs:masterfrom Jul 29, 2018
slokhorst:patch-1
Merged
Update integration docs: first method only works with Webpack#5555simonbrunel merged 2 commits intochartjs:masterfrom slokhorst:patch-1
simonbrunel merged 2 commits intochartjs:masterfrom
slokhorst:patch-1
Conversation
Contributor
|
It seems like this works for people who are using Webpack. I wonder if we should just update the heading from |
Contributor
Author
|
@benmccann thanks for clarifying! I've changed the heading to "Webpack" as you suggested. |
slokhorst
changed the title
simonbrunel
approved these changes
Jul 29, 2018
benmccann
approved these changes
Jul 29, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is broken, as mentioned in #5179.
It's really frustrating to advertise this as working while it's actually known to be broken.