Add support for Shadow DOM#5585
Merged
simonbrunel merged 4 commits intochartjs:masterfrom Jul 7, 2018
Merged
Conversation
simonbrunel
changed the title
simonbrunel
requested changes
Jun 24, 2018
Member
simonbrunel
left a comment
simonbrunel
left a comment
There was a problem hiding this comment.
Is it the only changes needed to support shadow DOM?
src/core/core.helpers.js
Outdated
|
|
||
| return padding.indexOf('%') > -1 ? parentDimension / parseInt(padding, 10) : parseInt(padding, 10); | ||
| }; | ||
| helpers.getParentNode = function(domNode) { |
Member
There was a problem hiding this comment.
This method should be private (and at some point will be moved in the dom platform implementation):
/**
* @private
*/
helpers._getParentNode = function(node) {| return; | ||
| } | ||
|
|
||
| var shadow = div.attachShadow({mode: 'closed'}); |
Member
There was a problem hiding this comment.
Do we reach this point when tests are executed by our CI / Travis?
Contributor
Author
There was a problem hiding this comment.
Yes in Chrome, not in Firefox.
Contributor
Author
IMO, yes since other features are working correctly in my app. |
simonbrunel
approved these changes
Jul 7, 2018
Member
|
Thanks @reda-alaoui |
|
Is this fix already available in the latest stable version? |
gofreddo
added a commit
to gofreddo/vue-chartjs
that referenced
this pull request
Oct 31, 2018
Update package.json. Bump chart.js version to 2.7.3. We're using vue-chartjs in a web component. Shadow DOM support was added in Version 2.7.3 chartjs/Chart.js#5585 .
1 task
apertureless
pushed a commit
to apertureless/vue-chartjs
that referenced
this pull request
Nov 8, 2018
Update package.json. Bump chart.js version to 2.7.3. We're using vue-chartjs in a web component. Shadow DOM support was added in Version 2.7.3 chartjs/Chart.js#5585 . ### Fix or Enhancement? - [ ] All tests passed ### Environment - OS: Write here - NPM Version: Write here
This was referenced Nov 10, 2018
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
Bajram-Useni
pushed a commit
to rahasiasutarto/vue-chartjs
that referenced
this pull request
Jan 21, 2025
Update package.json. Bump chart.js version to 2.7.3. We're using vue-chartjs in a web component. Shadow DOM support was added in Version 2.7.3 chartjs/Chart.js#5585 . ### Fix or Enhancement? - [ ] All tests passed ### Environment - OS: Write here - NPM Version: Write here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://developer.mozilla.org/en-US/docs/Web/API/ShadowRoot/host
Fix #5583