Conversation
etimberg
previously approved these changes
Jul 9, 2018
Member
etimberg
left a comment
etimberg
left a comment
There was a problem hiding this comment.
Looks good (but I'm biased on this one). I like the idea of separating out the cleanup from the other PR.
simonbrunel
reviewed
Sep 16, 2018
src/plugins/plugin.filler.js
Outdated
| d0 = isDrawable(p0); | ||
| d1 = isDrawable(p1); | ||
|
|
||
| if (loop && loopOffset === undefined && d0) { |
Member
There was a problem hiding this comment.
Looks strange that these changes have no impact on unit tests? And shouldn't we add new tests?
Member
There was a problem hiding this comment.
I think this might have been pulled over from the original PR that I opened. It could be removed
Contributor
Author
There was a problem hiding this comment.
I've removed this file from the PR
benmccann
force-pushed
the
radar-cleanup
branch
from
e049019 to
3f38152
Compare
etimberg
approved these changes
Sep 27, 2018
simonbrunel
approved these changes
Oct 21, 2018
This was referenced Mar 4, 2020
This was referenced Mar 9, 2020
This was referenced Apr 14, 2020
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@etimberg I was going to try to take a look at #5359 to try to help debug it and see why the tests were failing. I noticed that most of the changes were cleanup and not related to span gaps. I thought that splitting the PR into two would help reduce the amount of changes we'd need to inspect to understand which lines were responsible for the failing tests and make the PR easier to review.