Fix For Adding And Removing Datasets For Bar Samples#5663
Merged
simonbrunel merged 1 commit intochartjs:masterfrom Aug 8, 2018
Merged
Fix For Adding And Removing Datasets For Bar Samples#5663simonbrunel merged 1 commit intochartjs:masterfrom
simonbrunel merged 1 commit intochartjs:masterfrom
Conversation
simonbrunel
approved these changes
Aug 8, 2018
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
Account for zero indexing of arrays when creating a name for an added dataset and remove the last dataset in the array when removing a dataset rather than removing the first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #5662
Now accounts for zero indexing of arrays when creating a name for an added dataset.
Now removes the last dataset in the array when removing a dataset rather than removing the first.