Adding Accessibility page#5719
Merged
simonbrunel merged 3 commits intochartjs:masterfrom Sep 11, 2018
wuweiweiwu:issue-5687
Merged
Adding Accessibility page#5719simonbrunel merged 3 commits intochartjs:masterfrom wuweiweiwu:issue-5687
simonbrunel merged 3 commits intochartjs:masterfrom
wuweiweiwu:issue-5687
Conversation
benmccann
reviewed
Sep 5, 2018
benmccann
reviewed
Sep 6, 2018
benmccann
reviewed
Sep 6, 2018
docs/general/accessibility.md
Outdated
| @@ -0,0 +1,39 @@ | |||
| # Accessible Charts | |||
|
|
|||
| Chart.js charts are rendered on user provided `canvas` elements. Thus it is up to the user to create the `canvas` element in a way that is accessible. The `canvas` element has support in all browsers and will render on screen but the `canvas` content will not be accessible to screen readers. | |||
Contributor
There was a problem hiding this comment.
nit: it should be on a user provided
Contributor
Author
There was a problem hiding this comment.
I used plural charts and plural elements. I believe that is grammatically correct.
benmccann
reviewed
Sep 6, 2018
benmccann
previously approved these changes
Sep 6, 2018
etimberg
approved these changes
Sep 10, 2018
simonbrunel
approved these changes
Sep 11, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #5687
Added an accessibility page under
general/accessibilityin docs