Ensure that when we check typeof x == 'number' we also check instanceof Number#5752
Closed
etimberg wants to merge 3 commits intochartjs:masterfrom
Closed
Ensure that when we check typeof x == 'number' we also check instanceof Number#5752etimberg wants to merge 3 commits intochartjs:masterfrom
etimberg wants to merge 3 commits intochartjs:masterfrom
Conversation
Contributor
|
Maybe we should add a |
simonbrunel
previously approved these changes
Oct 8, 2018
Member
simonbrunel
left a comment
simonbrunel
left a comment
There was a problem hiding this comment.
I agree with @benmccann, we could refactor this method in helpers.core.js with associated unit tests to prevent regressions.
etimberg
force-pushed
the
number-instance
branch
from
1e69c98 to
24ac870
Compare
Member
Author
|
I created the helper function and used it where possible. I had the helper function return false for non-numeric types. This means I couldn't use it in |
simonbrunel
approved these changes
Oct 21, 2018
benmccann
approved these changes
Oct 22, 2018
benmccann
approved these changes
Oct 22, 2018
benmccann
approved these changes
Oct 22, 2018
benmccann
approved these changes
Oct 22, 2018
benmccann
approved these changes
Oct 22, 2018
benmccann
approved these changes
Oct 22, 2018
benmccann
approved these changes
Oct 22, 2018
benmccann
approved these changes
Oct 22, 2018
benmccann
approved these changes
Oct 22, 2018
benmccann
approved these changes
Oct 22, 2018
benmccann
approved these changes
Oct 22, 2018
benmccann
approved these changes
Oct 22, 2018
benmccann
approved these changes
Oct 22, 2018
Contributor
|
I approve this PR. GitHub is having trouble right now, so I can use the review functionality. Go ahead and merge when you're ready |
benmccann
approved these changes
Oct 22, 2018
benmccann
approved these changes
Oct 22, 2018
benmccann
approved these changes
Oct 22, 2018
Member
|
This is merged, twice ... GitHub have some trouble indeed. Closing manually to prevent a third merge. |
benmccann
pushed a commit
to benmccann/Chart.js
that referenced
this pull request
Oct 24, 2018
This was referenced Mar 4, 2020
This was referenced Mar 9, 2020
This was referenced Apr 14, 2020
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should resolve #3124 but I still need to write some tests