Make bar styling options scriptable#5780
Merged
simonbrunel merged 1 commit intochartjs:masterfrom Nov 12, 2018
Merged
Conversation
Member
Author
|
About the CodeClimate issue, I'm going to see how to refactor it when introducing scriptable options for the line chart, which is a bit different because of the inconsistent option naming between the dataset and the |
etimberg
previously approved these changes
Oct 21, 2018
benmccann
reviewed
Oct 22, 2018
benmccann
reviewed
Oct 24, 2018
benmccann
reviewed
Oct 24, 2018
benmccann
previously approved these changes
Oct 24, 2018
Contributor
benmccann
left a comment
There was a problem hiding this comment.
Lgtm. I think there's one unused variable, but otherwise feel free to merge
etimberg
previously approved these changes
Oct 24, 2018
The bar `backgroundColor`, `borderColor`, `borderWidth` and `borderSkipped` options are now scriptable (unit tests, docs and a basic sample). Also fix the gulp task that generates the documentation on Windows.
dd33a8e to
431709a
Compare
Member
Author
|
@benmccann @etimberg I merged this one because you previously approved it (I just rebased since and addressed @benmccann comment). |
Merged
This was referenced Mar 4, 2020
This was referenced Mar 9, 2020
This was referenced Apr 14, 2020
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
The bar `backgroundColor`, `borderColor`, `borderWidth` and `borderSkipped` options are now scriptable (unit tests, docs and a basic sample). Also fix the gulp task that generates the documentation on Windows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bar
backgroundColor,borderColor,borderWidthandborderSkippedoptions are now scriptable (unit tests, docs and a basic sample). Also fix the gulp task that generates the documentation on Windows.For example:
Fixes #5302