Consistent use of punctuation and quick review in docs#5796
Merged
simonbrunel merged 2 commits intochartjs:masterfrom Nov 2, 2018
bartdeslagmulder:fix-typos
Merged
Consistent use of punctuation and quick review in docs#5796simonbrunel merged 2 commits intochartjs:masterfrom bartdeslagmulder:fix-typos
simonbrunel merged 2 commits intochartjs:masterfrom
bartdeslagmulder:fix-typos
Conversation
benmccann
previously approved these changes
Oct 31, 2018
Contributor
|
I don't feel like this PR is creating a lot of value, but it isn't hurting anything either. I'm fine to either merge or close as the other maintainers see fit |
simonbrunel
requested changes
Nov 1, 2018
Member
simonbrunel
left a comment
simonbrunel
left a comment
There was a problem hiding this comment.
Thanks @bartdeslagmulder, can you please address my few comments?
I'm fine with merging this PR since it brings more consistency in the doc.
Contributor
Author
|
@simonbrunel done! |
This was referenced Mar 4, 2020
This was referenced Mar 9, 2020
This was referenced Apr 14, 2020
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.