Check pixel values within the logarithmic scale unit test using the pixel proximity matcher#5833
Merged
simonbrunel merged 1 commit intochartjs:masterfrom Nov 14, 2018
Merged
Conversation
benmccann
approved these changes
Nov 14, 2018
simonbrunel
approved these changes
Nov 14, 2018
This was referenced Mar 4, 2020
This was referenced Mar 9, 2020
This was referenced Apr 14, 2020
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, unit tests for the logarithmic scale within
scale.logarithmic.tests.jsused the precisetoBematcher to compare pixel values instead of the more appropriatetoBeCloseToPixelmatcher. This lead to failed test cases due to floating point inaccuracies and is inconsistent when compared toscale.linear.tests.js.This PR resolves this issue by replacing matchers for explicit pixel comparisons.
Fixes #5829.