Moved drawing of radial lines before drawing the tick labels#5855
Merged
simonbrunel merged 1 commit intochartjs:masterfrom Nov 27, 2018
Merged
Moved drawing of radial lines before drawing the tick labels#5855simonbrunel merged 1 commit intochartjs:masterfrom
simonbrunel merged 1 commit intochartjs:masterfrom
Conversation
…at the radial lines are not drawn on top of the tick labels and their backdrop.
etimberg
approved these changes
Nov 25, 2018
Member
|
@nagix since you worked on this scale recently, do you think of any issue moving the order of drawing? |
Contributor
|
I don't see any issues. This looks good to me. |
nagix
approved these changes
Nov 26, 2018
Member
|
@fhp do you have a fiddle that shows the issue this PR is trying to solve (or an associated ticket)? We are also drawing text in |
Contributor
Author
|
@simonbrunel yes: http://jsfiddle.net/ajbrk59c/ And using this fix: http://jsfiddle.net/7xL3jtzk/ (change is in the used dependency) I'm not very familiar with the Chart.js codebase, so I am unsure if it introduces other issues. |
Contributor
|
As point labels are drawn outside the outermost circle, I think there is no problem. |
Member
|
Thanks @fhp |
This was referenced Mar 4, 2020
This was referenced Mar 9, 2020
This was referenced Apr 14, 2020
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
Moved drawing of radial lines before drawing the tick labels, such that the radial lines are not drawn on top of the tick labels and their backdrop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
such that the radial lines are not drawn on top of the tick labels and their backdrop.