Remove gaps on the left and right when the axis offset is set to true#5884
Merged
simonbrunel merged 1 commit intochartjs:masterfrom Dec 5, 2018
Merged
Remove gaps on the left and right when the axis offset is set to true#5884simonbrunel merged 1 commit intochartjs:masterfrom
simonbrunel merged 1 commit intochartjs:masterfrom
Conversation
etimberg
approved these changes
Dec 5, 2018
simonbrunel
approved these changes
Dec 5, 2018
Member
|
Thanks @nagix |
Member
|
Are you sure that #5818 is fixed by this PR? |
Contributor
Author
This was referenced Mar 4, 2020
This was referenced Mar 9, 2020
This was referenced Apr 14, 2020
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the
offsetaxis option is set totrue, extra margins are added to the left and right edges depending on the tick label widths. This PR removes them by taking into account the tick offsets from the edges.Version 2.7.3: https://jsfiddle.net/nagix/jwnkbf84/
This PR: https://jsfiddle.net/nagix/qz0vyed8/
Fixes #5818