Fix calculateBarValuePixels when data is numeric strings#5892
Closed
kurkle wants to merge 2 commits intochartjs:masterfrom
Closed
Fix calculateBarValuePixels when data is numeric strings#5892kurkle wants to merge 2 commits intochartjs:masterfrom
kurkle wants to merge 2 commits intochartjs:masterfrom
Conversation
Contributor
|
@kurkle I think there is something wrong with your PR. It has 7 commits touching 27 files, which I think is more than you meant to edit. I'd suggest using a branch instead of developing on your |
Member
Author
|
Failed miserably on rebasing, it seems. Will fix tomorrow. |
kurkle
force-pushed
the
master
branch
2 times, most recently
from
1d68108 to
994497c
Compare
nagix
reviewed
Dec 21, 2018
Member
Author
|
|
Member
Author
|
Closing to free my master branch. Will create a new PR with tests added later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #5862
Also fixes minBarLength for in-middle zeros on stack.
Pen: https://codepen.io/kurkle/pen/KrjXxL (updated)