(re)allow modifying ticks in afterBuildTicks#5913
Merged
simonbrunel merged 3 commits intochartjs:masterfrom Jan 11, 2019
Merged
(re)allow modifying ticks in afterBuildTicks#5913simonbrunel merged 3 commits intochartjs:masterfrom
simonbrunel merged 3 commits intochartjs:masterfrom
Conversation
Member
|
I'm not sure why I didn't think about that solution when refactoring this part of the scales, maybe because I was planning to deprecate all those callbacks. Anyway, looks like a good solution for now :) To get the same results as #4749 (
It's already public via @kurkle can you add a unit test? |
3ed0c88 to
5ee394f
Compare
Contributor
|
@kurkle this PR will need to be rebased as well |
…/EGKWgM?editors=0010
etimberg
previously approved these changes
Jan 3, 2019
simonbrunel
reviewed
Jan 10, 2019
benmccann
reviewed
Jan 10, 2019
simonbrunel
reviewed
Jan 10, 2019
benmccann
reviewed
Jan 10, 2019
simonbrunel
approved these changes
Jan 10, 2019
etimberg
approved these changes
Jan 10, 2019
This was referenced Mar 4, 2020
This was referenced Mar 9, 2020
This was referenced Apr 14, 2020
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A workaround proposal to regain lost functionality.
The 'internal' tick objects are exposed, but I only see it as a bonus for custom axis types.
Closes #4749
https://codepen.io/kurkle/pen/EGKWgM?editors=0010