Return correct label for value type axis#5920
Merged
simonbrunel merged 9 commits intochartjs:masterfrom Jan 17, 2019
Merged
Conversation
benmccann
reviewed
Dec 19, 2018
benmccann
reviewed
Dec 19, 2018
benmccann
reviewed
Dec 19, 2018
simonbrunel
requested changes
Dec 21, 2018
kurkle
commented
Jan 2, 2019
simonbrunel
reviewed
Jan 2, 2019
Contributor
|
@kurkle this change will have to be rebased |
benmccann
reviewed
Jan 9, 2019
benmccann
reviewed
Jan 10, 2019
benmccann
reviewed
Jan 10, 2019
benmccann
reviewed
Jan 10, 2019
benmccann
reviewed
Jan 10, 2019
benmccann
previously approved these changes
Jan 10, 2019
etimberg
previously approved these changes
Jan 11, 2019
benmccann
reviewed
Jan 13, 2019
benmccann
reviewed
Jan 13, 2019
benmccann
reviewed
Jan 13, 2019
Member
Author
|
Another way of fixing this, thoughts? |
benmccann
previously approved these changes
Jan 15, 2019
Member
|
@kurkle I think that's the solution I like the most. Since we are moving these methods in the base class, it may be the opportunity to make them explicitly private (prefixed by '_')? (IIRC, there was no "private" policy when I introduced these methods). |
Member
Author
done |
etimberg
approved these changes
Jan 16, 2019
simonbrunel
approved these changes
Jan 17, 2019
This was referenced Mar 4, 2020
This was referenced Mar 9, 2020
This was referenced Apr 14, 2020
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5708
https://codepen.io/kurkle/pen/bOepaQ (updated to 4abdc59)